Commit 84e7a946 authored Jun 22, 2020 by Paul Cercueil Committed by Linus Walleij Jul 07, 2020

pinctrl: ingenic: Properly detect GPIO direction when configured for IRQ



The PAT1 register contains information about the IRQ type (edge/level)
for input GPIOs with IRQ enabled, and the direction for non-IRQ GPIOs.
So it makes sense to read it only if the GPIO has no interrupt
configured, otherwise input GPIOs configured for level IRQs are
misdetected as output GPIOs.

Fixes: ebd66514 ("pinctrl: ingenic: Implement .get_direction for GPIO chips")
Reported-by: João Henrique <johnnyonflame@hotmail.com>
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20200622214548.265417-2-paul@crapouillou.net


Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 1c95348b

drivers/pinctrl/pinctrl-ingenic.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1958,7 +1958,8 @@ static int ingenic_gpio_get_direction(struct gpio_chip *gc, unsigned int offset)
		unsigned int pin = gc->base + offset;

		if (jzpc->info->version >= ID_JZ4760) {
		if (ingenic_get_pin_config(jzpc, pin, JZ4760_GPIO_PAT1))
		if (ingenic_get_pin_config(jzpc, pin, JZ4760_GPIO_INT) \|\|
		ingenic_get_pin_config(jzpc, pin, JZ4760_GPIO_PAT1))
		return GPIO_LINE_DIRECTION_IN;
		return GPIO_LINE_DIRECTION_OUT;
		}

Admin message