Commit 84e5d136 authored by Qinglang Miao's avatar Qinglang Miao Committed by Jens Axboe
Browse files

bcache: Convert to DEFINE_SHOW_ATTRIBUTE 



Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

As inode->iprivate equals to third parameter of
debugfs_create_file() which is NULL. So it's equivalent
to original code logic.

Signed-off-by: default avatarQinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: default avatarColy Li <colyli@suse.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 7e59c506

drivers/md/bcache/closure.c

+3 −13
Original line number Diff line number Diff line
@@ -159,7 +159,7 @@ void closure_debug_destroy(struct closure *cl) 


static struct dentry *closure_debug;



static int debug_seq_show(struct seq_file *f, void *data)

static int debug_show(struct seq_file *f, void *data)

{

	struct closure *cl;
@@ -188,17 +188,7 @@ static int debug_seq_show(struct seq_file *f, void *data) 
	return 0;

}



static int debug_seq_open(struct inode *inode, struct file *file)

{

	return single_open(file, debug_seq_show, NULL);

}



static const struct file_operations debug_ops = {

	.owner		= THIS_MODULE,

	.open		= debug_seq_open,

	.read		= seq_read,

	.release	= single_release

};

DEFINE_SHOW_ATTRIBUTE(debug);



void  __init closure_debug_init(void)

{
@@ -209,7 +199,7 @@ void __init closure_debug_init(void) 
		 * about this.

		 */

		closure_debug = debugfs_create_file(

			"closures", 0400, bcache_debug, NULL, &debug_ops);

			"closures", 0400, bcache_debug, NULL, &debug_fops);

}

#endif

CRA Git | Maintained and supported by SUSTech CRA and CCSE