Commit 84cf4827 authored by Alex Porosanu's avatar Alex Porosanu Committed by Herbert Xu
Browse files

crypto: caam - fix RNG4 instantiation 



The RNG4 block in CAAM needs to be 'seeded' first before being used
for generating pseudo-random data. The 'seeding' is done by getting
entropy from the TRNG ring oscillator. The RTFRQMAX register controls
the maximum allowable number of samples that can be aquired during
an entropy sample. Depending on the clock at which the RNG4 block
(and for that matter the SEC block) runs, it's possible that a
hard-coded value for the maximum frequency is inadequate, i.e. more
samples than needed are taken. This is an error, and thus the RNG4
block doesn't get initialized.  The patch attempts to alleviate
this issue by trying with progressivly larger frequencies, until
the number of samples is adequate.
This patch also fixes how a descriptor is deemed as being finished:
instead of checking the VALID field in the DECO debug register,
it makes sure that the DECO is idle, by checking the DECO state field
of the said register.

Signed-off-by: default avatarAlex Porosanu <alexandru.porosanu@freescale.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent b2744dfd

drivers/crypto/caam/ctrl.c

+47 −16
Original line number Diff line number Diff line
@@ -82,7 +82,7 @@ static int instantiate_rng(struct device *ctrldev) 
	struct caam_drv_private *ctrlpriv = dev_get_drvdata(ctrldev);

	struct caam_full __iomem *topregs;

	unsigned int timeout = 100000;

	u32 *desc;

	u32 *desc, deco_dbg_reg;

	int i, ret = 0;



	desc = kmalloc(CAAM_CMD_SZ * 7, GFP_KERNEL | GFP_DMA);
@@ -112,9 +112,17 @@ static int instantiate_rng(struct device *ctrldev) 
	wr_reg32(&topregs->deco.jr_ctl_hi, DECO_JQCR_WHL | DECO_JQCR_FOUR);



	timeout = 10000000;

	while ((rd_reg32(&topregs->deco.desc_dbg) & DECO_DBG_VALID) &&

								 --timeout)

	do {

		deco_dbg_reg = rd_reg32(&topregs->deco.desc_dbg);

		/*

		 * If an error occured in the descriptor, then

		 * the DECO status field will be set to 0x0D

		 */

		if ((deco_dbg_reg & DESC_DBG_DECO_STAT_MASK) ==

		    DESC_DBG_DECO_STAT_HOST_ERR)

			break;

		cpu_relax();

	} while ((deco_dbg_reg & DESC_DBG_DECO_STAT_VALID) && --timeout);



	if (!timeout) {

		dev_err(ctrldev, "failed to instantiate RNG\n");
@@ -128,10 +136,12 @@ out: 
}



/*

 * By default, the TRNG runs for 200 clocks per sample;

 * 1600 clocks per sample generates better entropy.

 * kick_trng - sets the various parameters for enabling the initialization

 *	       of the RNG4 block in CAAM

 * @pdev - pointer to the platform device

 * @ent_delay - Defines the length (in system clocks) of each entropy sample.

 */

static void kick_trng(struct platform_device *pdev)

static void kick_trng(struct platform_device *pdev, int ent_delay)

{

	struct device *ctrldev = &pdev->dev;

	struct caam_drv_private *ctrlpriv = dev_get_drvdata(ctrldev);
@@ -144,14 +154,31 @@ static void kick_trng(struct platform_device *pdev) 


	/* put RNG4 into program mode */

	setbits32(&r4tst->rtmctl, RTMCTL_PRGM);

	/* 1600 clocks per sample */



	/*

	 * Performance-wise, it does not make sense to

	 * set the delay to a value that is lower

	 * than the last one that worked (i.e. the state handles

	 * were instantiated properly. Thus, instead of wasting

	 * time trying to set the values controlling the sample

	 * frequency, the function simply returns.

	 */

	val = (rd_reg32(&r4tst->rtsdctl) & RTSDCTL_ENT_DLY_MASK)

	      >> RTSDCTL_ENT_DLY_SHIFT;

	if (ent_delay <= val) {

		/* put RNG4 into run mode */

		clrbits32(&r4tst->rtmctl, RTMCTL_PRGM);

		return;

	}



	val = rd_reg32(&r4tst->rtsdctl);

	val = (val & ~RTSDCTL_ENT_DLY_MASK) | (1600 << RTSDCTL_ENT_DLY_SHIFT);

	val = (val & ~RTSDCTL_ENT_DLY_MASK) |

	      (ent_delay << RTSDCTL_ENT_DLY_SHIFT);

	wr_reg32(&r4tst->rtsdctl, val);

	/* min. freq. count */

	wr_reg32(&r4tst->rtfrqmin, 400);

	/* max. freq. count */

	wr_reg32(&r4tst->rtfrqmax, 6400);

	/* min. freq. count, equal to 1/4 of the entropy sample length */

	wr_reg32(&r4tst->rtfrqmin, ent_delay >> 2);

	/* max. freq. count, equal to 8 times the entropy sample length */

	wr_reg32(&r4tst->rtfrqmax, ent_delay << 3);

	/* put RNG4 into run mode */

	clrbits32(&r4tst->rtmctl, RTMCTL_PRGM);

}
@@ -192,7 +219,7 @@ EXPORT_SYMBOL(caam_get_era); 
/* Probe routine for CAAM top (controller) level */

static int caam_probe(struct platform_device *pdev)

{

	int ret, ring, rspec;

	int ret, ring, rspec, ent_delay = RTSDCTL_ENT_DLY_MIN;

	u64 caam_id;

	struct device *dev;

	struct device_node *nprop, *np;
@@ -302,9 +329,13 @@ static int caam_probe(struct platform_device *pdev) 
	 */

	if ((cha_vid & CHA_ID_RNG_MASK) >> CHA_ID_RNG_SHIFT >= 4 &&

	    !(rd_reg32(&topregs->ctrl.r4tst[0].rdsta) & RDSTA_IF0)) {

		kick_trng(pdev);

		do {

			kick_trng(pdev, ent_delay);

			ret = instantiate_rng(dev);

			ent_delay += 400;

		} while ((ret == -EIO) && (ent_delay < RTSDCTL_ENT_DLY_MAX));

		if (ret) {

			dev_err(dev, "failed to instantiate RNG");

			caam_remove(pdev);

			return ret;

		}

drivers/crypto/caam/regs.h

+5 −2
Original line number Diff line number Diff line
@@ -255,6 +255,8 @@ struct rng4tst { 
	};

#define RTSDCTL_ENT_DLY_SHIFT 16

#define RTSDCTL_ENT_DLY_MASK (0xffff << RTSDCTL_ENT_DLY_SHIFT)

#define RTSDCTL_ENT_DLY_MIN 1200

#define RTSDCTL_ENT_DLY_MAX 12800

	u32 rtsdctl;		/* seed control register */

	union {

		u32 rtsblim;	/* PRGM=1: sparse bit limit register */
@@ -706,12 +708,13 @@ struct caam_deco { 
	u32 rsvd29[48];

	u32 descbuf[64];	/* DxDESB - Descriptor buffer */

	u32 rscvd30[193];

#define DESC_DBG_DECO_STAT_HOST_ERR	0x00D00000

#define DESC_DBG_DECO_STAT_VALID	0x80000000

#define DESC_DBG_DECO_STAT_MASK		0x00F00000

	u32 desc_dbg;		/* DxDDR - DECO Debug Register */

	u32 rsvd31[126];

};



/* DECO DBG Register Valid Bit*/

#define DECO_DBG_VALID		0x80000000

#define DECO_JQCR_WHL		0x20000000

#define DECO_JQCR_FOUR		0x10000000

CRA Git | Maintained and supported by SUSTech CRA and CCSE