Commit 84c2cafa authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf tools: Reference count struct map 

We have pointers to struct map instances in several places, like in the
hist_entry instances, so we need a way to know when we can destroy them,
otherwise we may either keep leaking them or end up referencing deleted
instances.

Start fixing it by reference counting them.

This patch puts the reference count for struct map in place, replacing
direct map__delete() calls with map__put() ones and then grabbing a
reference count when adding it to the maps struct where maps for a
struct thread are kept.

Next we'll grab reference counts when setting pointers to struct map
instances, in places like in the hist_entry code.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-wi19xczk0t2a41r1i2chuio5@git.kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent facf3f06

tools/perf/util/machine.c

+2 −1
Original line number Diff line number Diff line
@@ -759,7 +759,6 @@ void machine__destroy_kernel_maps(struct machine *machine) 
				kmap->ref_reloc_sym = NULL;

		}



		map__delete(machine->vmlinux_maps[type]);

		machine->vmlinux_maps[type] = NULL;

	}

}
@@ -1247,6 +1246,7 @@ int machine__process_mmap2_event(struct machine *machine, 


	thread__insert_map(thread, map);

	thread__put(thread);

	map__put(map);

	return 0;



out_problem_map:
@@ -1297,6 +1297,7 @@ int machine__process_mmap_event(struct machine *machine, union perf_event *event 


	thread__insert_map(thread, map);

	thread__put(thread);

	map__put(map);

	return 0;



out_problem_map:

tools/perf/util/map.c

+15 −6
Original line number Diff line number Diff line
@@ -139,6 +139,7 @@ void map__init(struct map *map, enum map_type type, 
	map->groups   = NULL;

	map->referenced = false;

	map->erange_warned = false;

	atomic_set(&map->refcnt, 1);

}



struct map *map__new(struct machine *machine, u64 start, u64 len,
@@ -229,6 +230,12 @@ void map__delete(struct map *map) 
	free(map);

}



void map__put(struct map *map)

{

	if (map && atomic_dec_and_test(&map->refcnt))

		map__delete(map);

}



void map__fixup_start(struct map *map)

{

	struct rb_root *symbols = &map->dso->symbols[map->type];
@@ -448,7 +455,7 @@ static void __maps__purge(struct maps *maps) 


		next = rb_next(&pos->rb_node);

		rb_erase_init(&pos->rb_node, root);

		map__delete(pos);

		map__put(pos);

	}

}
@@ -458,7 +465,7 @@ static void __maps__purge_removed_maps(struct maps *maps) 


	list_for_each_entry_safe(pos, n, &maps->removed_maps, node) {

		list_del_init(&pos->node);

		map__delete(pos);

		map__put(pos);

	}

}
@@ -682,7 +689,7 @@ static int maps__fixup_overlappings(struct maps *maps, struct map *map, FILE *fp 


			if (before == NULL) {

				err = -ENOMEM;

				goto move_map;

				goto put_map;

			}



			before->end = map->start;
@@ -696,7 +703,7 @@ static int maps__fixup_overlappings(struct maps *maps, struct map *map, FILE *fp 


			if (after == NULL) {

				err = -ENOMEM;

				goto move_map;

				goto put_map;

			}



			after->start = map->end;
@@ -704,14 +711,14 @@ static int maps__fixup_overlappings(struct maps *maps, struct map *map, FILE *fp 
			if (verbose >= 2)

				map__fprintf(after, fp);

		}

move_map:

put_map:

		/*

		 * If we have references, just move them to a separate list.

		 */

		if (pos->referenced)

			list_add_tail(&pos->node, &maps->removed_maps);

		else

			map__delete(pos);

			map__put(pos);



		if (err)

			goto out;
@@ -772,6 +779,7 @@ static void __maps__insert(struct maps *maps, struct map *map) 


	rb_link_node(&map->rb_node, parent, p);

	rb_insert_color(&map->rb_node, &maps->entries);

	map__get(map);

}



void maps__insert(struct maps *maps, struct map *map)
@@ -784,6 +792,7 @@ void maps__insert(struct maps *maps, struct map *map) 
static void __maps__remove(struct maps *maps, struct map *map)

{

	rb_erase_init(&map->rb_node, &maps->entries);

	map__put(map);

}



void maps__remove(struct maps *maps, struct map *map)

tools/perf/util/map.h

+11 −0
Original line number Diff line number Diff line
@@ -52,6 +52,7 @@ struct map { 


	struct dso		*dso;

	struct map_groups	*groups;

	atomic_t		refcnt;

};



struct kmap {
@@ -150,6 +151,16 @@ struct map *map__new(struct machine *machine, u64 start, u64 len, 
struct map *map__new2(u64 start, struct dso *dso, enum map_type type);

void map__delete(struct map *map);

struct map *map__clone(struct map *map);



static inline struct map *map__get(struct map *map)

{

	if (map)

		atomic_inc(&map->refcnt);

	return map;

}



void map__put(struct map *map);



int map__overlap(struct map *l, struct map *r);

size_t map__fprintf(struct map *map, FILE *fp);

size_t map__fprintf_dsoname(struct map *map, FILE *fp);

tools/perf/util/probe-event.c

+3 −3
Original line number Diff line number Diff line
@@ -195,7 +195,7 @@ static void put_target_map(struct map *map, bool user) 
{

	if (map && user) {

		/* Only the user map needs to be released */

		map__delete(map);

		map__put(map);

	}

}
@@ -1791,7 +1791,7 @@ static int find_perf_probe_point_from_map(struct probe_trace_point *tp, 


out:

	if (map && !is_kprobe) {

		map__delete(map);

		map__put(map);

	}



	return ret;
@@ -2884,7 +2884,7 @@ int show_available_funcs(const char *target, struct strfilter *_filter, 
	dso__fprintf_symbols_by_name(map->dso, map->type, stdout);

end:

	if (user) {

		map__delete(map);

		map__put(map);

	}

	exit_symbol_maps();

tools/perf/util/symbol-elf.c

+2 −0
Original line number Diff line number Diff line
@@ -972,8 +972,10 @@ int dso__load_sym(struct dso *dso, struct map *map, 
					map->unmap_ip = map__unmap_ip;

					/* Ensure maps are correctly ordered */

					if (kmaps) {

						map__get(map);

						map_groups__remove(kmaps, map);

						map_groups__insert(kmaps, map);

						map__put(map);

					}

				}

CRA Git | Maintained and supported by SUSTech CRA and CCSE