Commit 84c2c562 authored Nov 28, 2008 by Phil Sutter Committed by Ralf Baechle Jan 30, 2009

MIPS: RB532: remove useless CF GPIO initialisation



As the pata-rb532-cf driver calls gpio_direction_input(), the calls to
rb532_gpio_set_func() and rb532_gpio_direction_input() are not needed since
the alternate function is automatically being disabled when changing the
GPIO pin direction.
The later two calls to rb532_gpio_set_{ilevel,istat}() are implicitly being
done by the IRQ initialisation of pata-rb532-cf.

Signed-off-by: Phil Sutter <n0-1@freewrt.org>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

parent 33763d57

arch/mips/rb532/gpio.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -259,12 +259,6 @@ int __init rb532_gpio_init(void)
		return -ENXIO;
		}

		/* configure CF_GPIO_NUM as CFRDY IRQ source */
		rb532_gpio_set_func(0, CF_GPIO_NUM);
		rb532_gpio_direction_input(&rb532_gpio_chip->chip, CF_GPIO_NUM);
		rb532_gpio_set_ilevel(1, CF_GPIO_NUM);
		rb532_gpio_set_istat(0, CF_GPIO_NUM);

		return 0;
		}
		arch_initcall(rb532_gpio_init);

Admin message