Commit 84bc9a58 authored by Larry Finger's avatar Larry Finger Committed by Kalle Valo
Browse files

rtlwifi: rtl8723be: Remove usage of private bit manipulation macros 



Besides the previously changed macros for the RX and TX descriptors.
the local macros are used in other places. These are replaced with
standard bit manipulation macros.

Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 1626f192

drivers/net/wireless/realtek/rtlwifi/rtl8723be/fw.h

+14 −16
Original line number Diff line number Diff line
@@ -83,37 +83,35 @@ enum rtl8723b_h2c_cmd { 




#define SET_H2CCMD_PWRMODE_PARM_MODE(__ph2ccmd, __val)			\

	SET_BITS_TO_LE_1BYTE(__ph2ccmd, 0, 8, __val)

	*(u8 *)__ph2ccmd = __val

#define SET_H2CCMD_PWRMODE_PARM_RLBM(__ph2ccmd, __val)			\

	SET_BITS_TO_LE_1BYTE((__ph2ccmd)+1, 0, 4, __val)

	u8p_replace_bits(__ph2ccmd + 1, __val, GENMASK(3, 0))

#define SET_H2CCMD_PWRMODE_PARM_SMART_PS(__ph2ccmd, __val)		\

	SET_BITS_TO_LE_1BYTE((__ph2ccmd)+1, 4, 4, __val)

	u8p_replace_bits(__ph2ccmd + 1, __val, GENMASK(7, 4))

#define SET_H2CCMD_PWRMODE_PARM_AWAKE_INTERVAL(__ph2ccmd, __val)	\

	SET_BITS_TO_LE_1BYTE((__ph2ccmd)+2, 0, 8, __val)

	*(u8 *)(__ph2ccmd + 2) = __val

#define SET_H2CCMD_PWRMODE_PARM_ALL_QUEUE_UAPSD(__ph2ccmd, __val)	\

	SET_BITS_TO_LE_1BYTE((__ph2ccmd)+3, 0, 8, __val)

	*(u8 *)(__ph2ccmd + 3) = __val

#define SET_H2CCMD_PWRMODE_PARM_PWR_STATE(__ph2ccmd, __val)		\

	SET_BITS_TO_LE_1BYTE((__ph2ccmd)+4, 0, 8, __val)

	*(u8 *)(__ph2ccmd + 4) = __val

#define SET_H2CCMD_PWRMODE_PARM_BYTE5(__ph2ccmd, __val)			\

	SET_BITS_TO_LE_1BYTE((__ph2ccmd) + 5, 0, 8, __val)

#define GET_88E_H2CCMD_PWRMODE_PARM_MODE(__ph2ccmd)			\

	LE_BITS_TO_1BYTE(__ph2ccmd, 0, 8)

	*(u8 *)(__ph2ccmd + 5) = __val



#define SET_H2CCMD_MSRRPT_PARM_OPMODE(__ph2ccmd, __val)		\

	SET_BITS_TO_LE_1BYTE(__ph2ccmd, 0, 1, __val)

	u8p_replace_bits(__ph2ccmd, __val, BIT(0))

#define SET_H2CCMD_MSRRPT_PARM_MACID_IND(__ph2ccmd, __val)	\

	SET_BITS_TO_LE_1BYTE(__ph2ccmd, 1, 1, __val)

	u8p_replace_bits(__ph2ccmd, __val, BIT(1))



#define SET_H2CCMD_RSVDPAGE_LOC_PROBE_RSP(__ph2ccmd, __val)		\

	SET_BITS_TO_LE_1BYTE(__ph2ccmd, 0, 8, __val)

	*(u8 *)(__ph2ccmd) = __val

#define SET_H2CCMD_RSVDPAGE_LOC_PSPOLL(__ph2ccmd, __val)		\

	SET_BITS_TO_LE_1BYTE((__ph2ccmd)+1, 0, 8, __val)

	*(u8 *)(__ph2ccmd + 1) = __val

#define SET_H2CCMD_RSVDPAGE_LOC_NULL_DATA(__ph2ccmd, __val)		\

	SET_BITS_TO_LE_1BYTE((__ph2ccmd)+2, 0, 8, __val)

	*(u8 *)(__ph2ccmd + 2) = __val

#define SET_H2CCMD_RSVDPAGE_LOC_QOS_NULL_DATA(__ph2ccmd, __val)	\

	SET_BITS_TO_LE_1BYTE((__ph2ccmd) + 3, 0, 8, __val)

	*(u8 *)(__ph2ccmd + 3) = __val

#define SET_H2CCMD_RSVDPAGE_LOC_BT_QOS_NULL_DATA(__ph2ccmd, __val)	\

	SET_BITS_TO_LE_1BYTE((__ph2ccmd) + 4, 0, 8, __val)

	*(u8 *)(__ph2ccmd + 4) = __val





void rtl8723be_fill_h2c_cmd(struct ieee80211_hw *hw, u8 element_id,

CRA Git | Maintained and supported by SUSTech CRA and CCSE