Commit 84a1c210 authored Nov 28, 2018 by huijin.park Committed by Boris Brezillon Dec 10, 2018

mtd: spi-nor: cast to u64 to avoid uint overflows



The "params->size" is defined as "u64".
And "info->sector_size" and "info->n_sectors" are defined as
unsigned int and u16.
Thus, u64 data might have strange data(loss data) if the result
overflows an unsigned int.
This patch casts "info->sector_size" to an u64.

Signed-off-by: huijin.park <huijin.park@samsung.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

parent 4cc106f8

drivers/mtd/spi-nor/spi-nor.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3270,7 +3270,7 @@ static int spi_nor_init_params(struct spi_nor *nor,
		memset(params, 0, sizeof(*params));

		/* Set SPI NOR sizes. */
		params->size = info->sector_size * info->n_sectors;
		params->size = (u64)info->sector_size * info->n_sectors;
		params->page_size = info->page_size;

		/* (Fast) Read settings. */

Admin message