Commit 8494cdea authored Sep 24, 2015 by Andrzej Hajda Committed by Mark Brown Sep 25, 2015

spi: davinci: fix handling platform_get_irq result

The function can return negative value.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107



Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 6ff33f39

drivers/spi/spi-davinci.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -992,11 +992,12 @@ static int davinci_spi_probe(struct platform_device *pdev)
		goto free_master;
		}

		dspi->irq = platform_get_irq(pdev, 0);
		if (dspi->irq <= 0) {
		ret = platform_get_irq(pdev, 0);
		if (ret == 0)
		ret = -EINVAL;
		if (ret < 0)
		goto free_master;
		}
		dspi->irq = ret;

		ret = devm_request_threaded_irq(&pdev->dev, dspi->irq, davinci_spi_irq,
		dummy_thread_fn, 0, dev_name(&pdev->dev), dspi);

Admin message