Commit 84908426 authored Jun 27, 2017 by Arnd Bergmann Committed by Steve French Jul 05, 2017

cifs: hide unused functions



Some functions are only referenced under an #ifdef, causing a harmless
warning:

fs/cifs/smb2ops.c:1374:1: error: 'get_smb2_acl' defined but not used [-Werror=unused-function]

We could mark them __maybe_unused or add another #ifdef, I picked
the second approach here.

Fixes: b3fdda4d1e1b ("cifs: Use smb 2 - 3 and cifsacl mount options getacl functions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Steve French <smfrench@gmail.com>

parent 2f1afe25

fs/cifs/smb2ops.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1288,6 +1288,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon,
		return rc;
		}

		#ifdef CONFIG_CIFS_ACL
		static struct cifs_ntsd *
		get_smb2_acl_by_fid(struct cifs_sb_info *cifs_sb,
		const struct cifs_fid cifsfid, u32 pacllen)
		@@ -1387,7 +1388,7 @@ get_smb2_acl(struct cifs_sb_info *cifs_sb,
		cifsFileInfo_put(open_file);
		return pntsd;
		}

		#endif

		static long smb3_zero_range(struct file file, struct cifs_tcon tcon,
		loff_t offset, loff_t len, bool keep_size)

Admin message