Commit 8474e5ca authored by Christian Borntraeger's avatar Christian Borntraeger
Browse files

KVM: s390: count invalid yields 



To analyze some performance issues with lock contention and scheduling
it is nice to know when diag9c did not result in any action or when
no action was tried.

Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
Reviewed-by: default avatarCornelia Huck <cohuck@redhat.com>
parent efec8d21

arch/s390/include/asm/kvm_host.h

+1 −0
Original line number Diff line number Diff line
@@ -392,6 +392,7 @@ struct kvm_vcpu_stat { 
	u64 diagnose_10;

	u64 diagnose_44;

	u64 diagnose_9c;

	u64 diagnose_9c_ignored;

	u64 diagnose_258;

	u64 diagnose_308;

	u64 diagnose_500;

arch/s390/kvm/diag.c

+14 −4
Original line number Diff line number Diff line
@@ -158,14 +158,24 @@ static int __diag_time_slice_end_directed(struct kvm_vcpu *vcpu) 


	tid = vcpu->run->s.regs.gprs[(vcpu->arch.sie_block->ipa & 0xf0) >> 4];

	vcpu->stat.diagnose_9c++;

	VCPU_EVENT(vcpu, 5, "diag time slice end directed to %d", tid);



	/* yield to self */

	if (tid == vcpu->vcpu_id)

		return 0;

		goto no_yield;



	/* yield to invalid */

	tcpu = kvm_get_vcpu_by_id(vcpu->kvm, tid);

	if (tcpu)

		kvm_vcpu_yield_to(tcpu);

	if (!tcpu)

		goto no_yield;



	if (kvm_vcpu_yield_to(tcpu) <= 0)

		goto no_yield;



	VCPU_EVENT(vcpu, 5, "diag time slice end directed to %d: done", tid);

	return 0;

no_yield:

	VCPU_EVENT(vcpu, 5, "diag time slice end directed to %d: ignored", tid);

	vcpu->stat.diagnose_9c_ignored++;

	return 0;

}

arch/s390/kvm/kvm-s390.c

+1 −0
Original line number Diff line number Diff line
@@ -155,6 +155,7 @@ struct kvm_stats_debugfs_item debugfs_entries[] = { 
	{ "instruction_diag_10", VCPU_STAT(diagnose_10) },

	{ "instruction_diag_44", VCPU_STAT(diagnose_44) },

	{ "instruction_diag_9c", VCPU_STAT(diagnose_9c) },

	{ "diag_9c_ignored", VCPU_STAT(diagnose_9c_ignored) },

	{ "instruction_diag_258", VCPU_STAT(diagnose_258) },

	{ "instruction_diag_308", VCPU_STAT(diagnose_308) },

	{ "instruction_diag_500", VCPU_STAT(diagnose_500) },

CRA Git | Maintained and supported by SUSTech CRA and CCSE