Commit 846f4045 authored Dec 16, 2010 by Steven Whitehouse

GFS2: Don't flush delete workqueue when releasing the transaction lock



There is no requirement to flush the delete workqueue before a
gfs2 filesystem is suspended. The workqueue's work will just
be suspended along with the rest of the tasks on the filesystem.

The resolves a deadlock situation where the transaction lock's
demotion code was trying to flush the delete workqueue while at
the same time, the workqueue was waiting for the transaction
lock.

The delete workqueue is flushed by gfs2_make_fs_ro() already, so
that umount/remount are correctly protected anyway.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

parent bcd7278d

fs/gfs2/glops.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -325,7 +325,6 @@ static void trans_go_sync(struct gfs2_glock *gl)

		if (gl->gl_state != LM_ST_UNLOCKED &&
		test_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags)) {
		flush_workqueue(gfs2_delete_workqueue);
		gfs2_meta_syncfs(sdp);
		gfs2_log_shutdown(sdp);
		}

Admin message