Commit 844e4d66 authored Jun 06, 2014 by Joonsoo Kim Committed by Linus Torvalds Jun 06, 2014

slub: search partial list on numa_mem_id(), instead of numa_node_id()



Currently, if allocation constraint to node is NUMA_NO_NODE, we search a
partial slab on numa_node_id() node.  This doesn't work properly on a
system having memoryless nodes, since it can have no memory on that node
so there must be no partial slab on that node.

On that node, page allocation always falls back to numa_mem_id() first.
So searching a partial slab on numa_node_id() in that case is the proper
solution for the memoryless node case.

Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
Acked-by: David Rientjes <rientjes@google.com>
Acked-by: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Cc: Han Pingtian <hanpt@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 71abdc15

mm/slub.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1726,7 +1726,7 @@ static void get_partial(struct kmem_cache s, gfp_t flags, int node,
		struct kmem_cache_cpu *c)
		{
		void *object;
		int searchnode = (node == NUMA_NO_NODE) ? numa_node_id() : node;
		int searchnode = (node == NUMA_NO_NODE) ? numa_mem_id() : node;

		object = get_partial_node(s, get_node(s, searchnode), c, flags);
		if (object \|\| node != NUMA_NO_NODE)

Admin message