Commit 844c7a9f authored Dec 01, 2008 by Mark McLoughlin Committed by Avi Kivity Dec 31, 2008

KVM: remove the IRQ ACK notifier assertions



We will obviously never pass a NULL struct kvm_irq_ack_notifier* to
this functions. They are always embedded in the assigned device
structure, so the assertion add nothing.

The irqchip_in_kernel() assertion is very out of place - clearly
this little abstraction needs to know nothing about the upper
layer details.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>

parent efff9e53

virt/kvm/irq_comm.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -58,9 +58,6 @@ void kvm_notify_acked_irq(struct kvm *kvm, unsigned gsi)
		void kvm_register_irq_ack_notifier(struct kvm *kvm,
		struct kvm_irq_ack_notifier *kian)
		{
		/* Must be called with in-kernel IRQ chip, otherwise it's nonsense */
		ASSERT(irqchip_in_kernel(kvm));
		ASSERT(kian);
		hlist_add_head(&kian->link, &kvm->arch.irq_ack_notifier_list);
		}

Admin message