Commit 8447d950 authored Mar 21, 2012 by David Rientjes Committed by Linus Torvalds Mar 21, 2012

mm, oom: do not emit oom killer warning if chosen thread is already exiting



If a thread is chosen for oom kill and is already PF_EXITING, then the oom
killer simply sets TIF_MEMDIE and returns.  This allows the thread to have
access to memory reserves so that it may quickly exit.  This logic is
preceeded with a comment saying there's no need to alarm the sysadmin.
This patch adds truth to that statement.

There's no need to emit any warning about the oom condition if the thread
is already exiting since it will not be killed.  In this condition, just
silently return the oom killer since its only giving access to memory
reserves and is otherwise a no-op.

Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: David Rientjes <rientjes@google.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 647f2bdf

mm/oom_kill.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -445,9 +445,6 @@ static void oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,
		struct mm_struct *mm;
		unsigned int victim_points = 0;

		if (printk_ratelimit())
		dump_header(p, gfp_mask, order, memcg, nodemask);

		/*
		* If the task is already exiting, don't alarm the sysadmin or kill
		* its children or threads, just set TIF_MEMDIE so it can die quickly
		@@ -457,6 +454,9 @@ static void oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,
		return;
		}

		if (printk_ratelimit())
		dump_header(p, gfp_mask, order, memcg, nodemask);

		task_lock(p);
		pr_err("%s: Kill process %d (%s) score %d or sacrifice child\n",
		message, task_pid_nr(p), p->comm, points);

Admin message