USB: EHCI: remove bogus #error (843e56c0) · Commits · 戴 / test

The EHCI host controller driver can be built standalone now, without enabling any of the available bus glue drivers, so there is not really a reason to error out here: drivers/usb/host/ehci-hcd.c:1303:2: error: #error "missing bus glue for ehci-hcd" #error "missing bus glue for ehci-hcd" The alternative would be to change the Kconfig code to build the ehci-hcd module only if any of the symbols below are in fact enabled. Signed-off-by:

Arnd Bergmann <arnd@arndb.de> Acked-by:

Alan Stern <stern@rowland.harvard.edu> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/usb/host/ehci-hcd.c

+0 −17

Original line number	Diff line number	Diff line
		@@ -1286,23 +1286,6 @@ MODULE_LICENSE ("GPL");
		#define PLATFORM_DRIVER ehci_hcd_sead3_driver
		#endif

		#if !IS_ENABLED(CONFIG_USB_EHCI_PCI) && \
		!IS_ENABLED(CONFIG_USB_EHCI_HCD_PLATFORM) && \
		!IS_ENABLED(CONFIG_USB_CHIPIDEA_HOST) && \
		!IS_ENABLED(CONFIG_USB_EHCI_MXC) && \
		!IS_ENABLED(CONFIG_USB_EHCI_HCD_OMAP) && \
		!IS_ENABLED(CONFIG_USB_EHCI_HCD_ORION) && \
		!IS_ENABLED(CONFIG_USB_EHCI_HCD_SPEAR) && \
		!IS_ENABLED(CONFIG_USB_EHCI_S5P) && \
		!IS_ENABLED(CONFIG_USB_EHCI_HCD_AT91) && \
		!IS_ENABLED(CONFIG_USB_EHCI_MSM) && \
		!defined(PLATFORM_DRIVER) && \
		!defined(PS3_SYSTEM_BUS_DRIVER) && \
		!defined(OF_PLATFORM_DRIVER) && \
		!defined(XILINX_OF_PLATFORM_DRIVER)
		#error "missing bus glue for ehci-hcd"
		#endif

		static int __init ehci_hcd_init(void)
		{
		int retval = 0;

Admin message