mwifiex: fix the incorrect WARN_ON during suspend (84349698) · Commits · 戴 / test

During system suspend, there is a kernel WARNING issued if there is a pending command present. By marking the wait queue disabled after calling the command completion routine fixes it. Signed-off-by:

Vishal Thanki <vishalthanki@gmail.com> Signed-off-by:

Kalle Valo <kvalo@codeaurora.org>

drivers/net/wireless/marvell/mwifiex/cmdevt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1009,9 +1009,9 @@ mwifiex_cancel_all_pending_cmd(struct mwifiex_adapter *adapter)
		spin_lock_irqsave(&adapter->mwifiex_cmd_lock, cmd_flags);
		/* Cancel current cmd */
		if ((adapter->curr_cmd) && (adapter->curr_cmd->wait_q_enabled)) {
		adapter->curr_cmd->wait_q_enabled = false;
		adapter->cmd_wait_q.status = -1;
		mwifiex_complete_cmd(adapter, adapter->curr_cmd);
		adapter->curr_cmd->wait_q_enabled = false;
		/* no recycle probably wait for response */
		}
		/* Cancel all pending command */

Admin message