net/mlx5e: Print a warning when LRO feature is dropped or not allowed (842a2eb2) · Commits · 戴 / test

When user enables LRO via ethtool and if the RQ mode is legacy, mlx5e_fix_features drops the request without any explanation. Add netdev_warn to cover this case. Fixes: ("net/mlx5e: RX, Remove HW LRO support in legacy RQ") Signed-off-by:

Huy Nguyen <huyn@mellanox.com> Signed-off-by:

Saeed Mahameed <saeedm@mellanox.com>

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -3788,9 +3788,10 @@ static netdev_features_t mlx5e_fix_features(struct net_device *netdev,
		netdev_warn(netdev, "Dropping C-tag vlan stripping offload due to S-tag vlan\n");
		}
		if (!MLX5E_GET_PFLAG(params, MLX5E_PFLAG_RX_STRIDING_RQ)) {
		features &= ~NETIF_F_LRO;
		if (params->lro_en)
		if (features & NETIF_F_LRO) {
		netdev_warn(netdev, "Disabling LRO, not supported in legacy RQ\n");
		features &= ~NETIF_F_LRO;
		}
		}

		if (MLX5E_GET_PFLAG(params, MLX5E_PFLAG_RX_CQE_COMPRESS)) {

Admin message