Commit 8428817d authored Jan 05, 2019 by Dan Carpenter Committed by Steve French Jan 10, 2019

cifs: Fix a debug message



This debug message was never shown because it was checking for NULL
returns but extract_hostname() returns error pointers.

Fixes: 93d5cb51 ("cifs: Add support for failover in cifs_reconnect()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Paulo Alcantara <palcantara@suse.de>

parent 1bdbe227

fs/cifs/connect.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -433,9 +433,10 @@ static void reconn_inval_dfs_target(struct TCP_Server_Info *server,
		kfree(server->hostname);

		server->hostname = extract_hostname(name);
		if (!server->hostname) {
		cifs_dbg(FYI, "%s: failed to extract hostname from target: %d\n",
		__func__, -ENOMEM);
		if (IS_ERR(server->hostname)) {
		cifs_dbg(FYI,
		"%s: failed to extract hostname from target: %ld\n",
		__func__, PTR_ERR(server->hostname));
		}
		}

Admin message