Commit 84239b44 authored by YueHaibing's avatar YueHaibing Committed by David S. Miller
Browse files

ptp: fix debugfs_simple_attr.cocci warnings 



Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.

Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().

Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Acked-by: default avatarYangbo Lu <yangbo.lu@nxp.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f515220c

drivers/ptp/ptp_qoriq_debugfs.c

+8 −8
Original line number Diff line number Diff line
@@ -33,7 +33,7 @@ static int ptp_qoriq_fiper1_lpbk_set(void *data, u64 val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(ptp_qoriq_fiper1_fops, ptp_qoriq_fiper1_lpbk_get,

DEFINE_DEBUGFS_ATTRIBUTE(ptp_qoriq_fiper1_fops, ptp_qoriq_fiper1_lpbk_get,

			 ptp_qoriq_fiper1_lpbk_set, "%llu\n");



static int ptp_qoriq_fiper2_lpbk_get(void *data, u64 *val)
@@ -64,7 +64,7 @@ static int ptp_qoriq_fiper2_lpbk_set(void *data, u64 val) 
	return 0;

}



DEFINE_SIMPLE_ATTRIBUTE(ptp_qoriq_fiper2_fops, ptp_qoriq_fiper2_lpbk_get,

DEFINE_DEBUGFS_ATTRIBUTE(ptp_qoriq_fiper2_fops, ptp_qoriq_fiper2_lpbk_get,

			 ptp_qoriq_fiper2_lpbk_set, "%llu\n");



void ptp_qoriq_create_debugfs(struct qoriq_ptp *qoriq_ptp)
@@ -79,11 +79,11 @@ void ptp_qoriq_create_debugfs(struct qoriq_ptp *qoriq_ptp) 


	qoriq_ptp->debugfs_root = root;



	if (!debugfs_create_file("fiper1-loopback", 0600, root, qoriq_ptp,

				 &ptp_qoriq_fiper1_fops))

	if (!debugfs_create_file_unsafe("fiper1-loopback", 0600, root,

					qoriq_ptp, &ptp_qoriq_fiper1_fops))

		goto err_node;

	if (!debugfs_create_file("fiper2-loopback", 0600, root, qoriq_ptp,

				 &ptp_qoriq_fiper2_fops))

	if (!debugfs_create_file_unsafe("fiper2-loopback", 0600, root,

					qoriq_ptp, &ptp_qoriq_fiper2_fops))

		goto err_node;

	return;

CRA Git | Maintained and supported by SUSTech CRA and CCSE