Commit 841e3558 authored May 06, 2016 by He Kuang Committed by Arnaldo Carvalho de Melo May 09, 2016

perf callchain: Recording 'dwarf' callchains do not need DWARF unwinding support



There is no need to check for DWARF unwinding support when using the
'dwarf' callchain record method, as this will only ask the kernel to
collect stack dumps for later DWARF CFI processing, which can be done in
another machine, where the support for DWARF unwinding need to be
present.

Signed-off-by: He Kuang <hekuang@huawei.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1462525154-125656-2-git-send-email-hekuang@huawei.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent ea7c2851

tools/perf/util/util.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -507,7 +507,6 @@ int parse_callchain_record(const char arg, struct callchain_param param)
		"needed for --call-graph fp\n");
		break;

		#ifdef HAVE_DWARF_UNWIND_SUPPORT
		/* Dwarf style */
		} else if (!strncmp(name, "dwarf", sizeof("dwarf"))) {
		const unsigned long default_stack_dump_size = 8192;
		@@ -523,7 +522,6 @@ int parse_callchain_record(const char arg, struct callchain_param param)
		ret = get_stack_size(tok, &size);
		param->dump_size = size;
		}
		#endif /* HAVE_DWARF_UNWIND_SUPPORT */
		} else if (!strncmp(name, "lbr", sizeof("lbr"))) {
		if (!strtok_r(NULL, ",", &saveptr)) {
		param->record_mode = CALLCHAIN_LBR;

Admin message