Commit 840f53c3 authored Jan 07, 2014 by Wei Yongjun Committed by Brian Norris Jan 20, 2014

mtd: plat_nand: remove redundant return value check of platform_get_resource()



Remove unneeded error handling on the result of a call
to platform_get_resource() when the value is passed to
devm_ioremap_resource(). And move those two call together
to make the connection between them more clear.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>

parent 4968a412

drivers/mtd/nand/plat_nand.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -48,16 +48,13 @@ static int plat_nand_probe(struct platform_device *pdev)
		return -EINVAL;
		}

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		if (!res)
		return -ENXIO;

		/* Allocate memory for the device structure (and zero it) */
		data = devm_kzalloc(&pdev->dev, sizeof(struct plat_nand_data),
		GFP_KERNEL);
		if (!data)
		return -ENOMEM;

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		data->io_base = devm_ioremap_resource(&pdev->dev, res);
		if (IS_ERR(data->io_base))
		return PTR_ERR(data->io_base);

Admin message