Commit 83e14ea3 authored by Hans de Goede's avatar Hans de Goede
Browse files

drm/modes: parse_cmdline: Make various char pointers const 



We are not supposed to modify the passed in string, make char pointers
used in drm_mode_parse_cmdline_options() const char * where possible.

Acked-by: default avatarMaxime Ripard <mripard@kernel.org>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191118155134.30468-2-hdegoede@redhat.com
parent 8582e244

drivers/gpu/drm/drm_modes.c

+5 −5
Original line number Diff line number Diff line
@@ -1591,15 +1591,15 @@ static int drm_mode_parse_cmdline_int(const char *delim, unsigned int *int_ret) 
	return 0;

}



static int drm_mode_parse_cmdline_options(char *str, size_t len,

static int drm_mode_parse_cmdline_options(const char *str, size_t len,

					  const struct drm_connector *connector,

					  struct drm_cmdline_mode *mode)

{

	unsigned int deg, margin, rotation = 0;

	char *sep = str;

	const char *sep = str;



	while ((sep = strchr(sep, ','))) {

		char *delim, *option;

		const char *delim, *option;



		option = sep + 1;

		delim = strchr(option, '=');
@@ -1718,8 +1718,8 @@ bool drm_mode_parse_command_line_for_connector(const char *mode_option, 
	bool named_mode = false, parse_extras = false;

	unsigned int bpp_off = 0, refresh_off = 0, options_off = 0;

	unsigned int mode_end = 0;

	char *bpp_ptr = NULL, *refresh_ptr = NULL, *extra_ptr = NULL;

	char *options_ptr = NULL;

	const char *bpp_ptr = NULL, *refresh_ptr = NULL, *extra_ptr = NULL;

	const char *options_ptr = NULL;

	char *bpp_end_ptr = NULL, *refresh_end_ptr = NULL;

	int ret;

CRA Git | Maintained and supported by SUSTech CRA and CCSE