Commit 83d5f018 authored Feb 24, 2015 by Eric Sandeen Committed by Dave Chinner Feb 24, 2015

xfs: cancel failed transaction in xfs_fs_commit_blocks()



If xfs_trans_reserve fails we don't cancel the transaction,
and we'll leak the allocated transaction pointer.

Spotted by Coverity.

Signed-off-by: Eric Sandeen <ssandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>

parent fc921566

fs/xfs/xfs_pnfs.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -300,8 +300,10 @@ xfs_fs_commit_blocks(

		tp = xfs_trans_alloc(mp, XFS_TRANS_SETATTR_NOT_SIZE);
		error = xfs_trans_reserve(tp, &M_RES(mp)->tr_ichange, 0, 0);
		if (error)
		if (error) {
		xfs_trans_cancel(tp, 0);
		goto out_drop_iolock;
		}

		xfs_ilock(ip, XFS_ILOCK_EXCL);
		xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL);

Admin message