Commit 83a72953 authored Jun 29, 2018 by Hans Verkuil Committed by Mauro Carvalho Chehab Jul 04, 2018

media: vivid: fix gain when autogain is on



In the vivid driver you want gain to continuous change while autogain
is on. However, dev->jiffies_vid_cap doesn't actually change. It probably
did in the past, but changes in the code caused this to be a fixed value
that is only set when you start streaming.

Replace it by jiffies, which is always changing.

[mchehab@kernel.org: use jiffies_to_msecs() instead of dividing by HZ]

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent 9f84310d

drivers/media/platform/vivid/vivid-ctrls.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -295,7 +295,7 @@ static int vivid_user_vid_g_volatile_ctrl(struct v4l2_ctrl *ctrl)

		switch (ctrl->id) {
		case V4L2_CID_AUTOGAIN:
		dev->gain->val = dev->jiffies_vid_cap & 0xff;
		dev->gain->val = (jiffies_to_msecs(jiffies) / 1000) & 0xff;
		break;
		}
		return 0;

Admin message