Commit 83a1e53f authored by Seung-Woo Kim's avatar Seung-Woo Kim Committed by Casey Schaufler
Browse files

Smack: ignore private inode for file functions 

The access to fd from anon_inode is always failed because there is
no set xattr operations. So this patch fixes to ignore private
inode including anon_inode for file functions.

It was only ignored for smack_file_receive() to share dma-buf fd,
but dma-buf has other functions like ioctl and mmap.

Reference: https://lkml.org/lkml/2015/4/17/16



Signed-off-by: default avatarSeung-Woo Kim <sw0312.kim@samsung.com>
Signed-off-by: default avatarCasey Schaufler <casey@schaufler-ca.com>
parent 805b65a8

security/smack/smack_lsm.c

+12 −0
Original line number Diff line number Diff line
@@ -1647,6 +1647,9 @@ static int smack_file_ioctl(struct file *file, unsigned int cmd, 
	struct smk_audit_info ad;

	struct inode *inode = file_inode(file);



	if (unlikely(IS_PRIVATE(inode)))

		return 0;



	smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_PATH);

	smk_ad_setfield_u_fs_path(&ad, file->f_path);
@@ -1676,6 +1679,9 @@ static int smack_file_lock(struct file *file, unsigned int cmd) 
	int rc;

	struct inode *inode = file_inode(file);



	if (unlikely(IS_PRIVATE(inode)))

		return 0;



	smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_PATH);

	smk_ad_setfield_u_fs_path(&ad, file->f_path);

	rc = smk_curacc(smk_of_inode(inode), MAY_LOCK, &ad);
@@ -1702,6 +1708,9 @@ static int smack_file_fcntl(struct file *file, unsigned int cmd, 
	int rc = 0;

	struct inode *inode = file_inode(file);



	if (unlikely(IS_PRIVATE(inode)))

		return 0;



	switch (cmd) {

	case F_GETLK:

		break;
@@ -1755,6 +1764,9 @@ static int smack_mmap_file(struct file *file, 
	if (file == NULL)

		return 0;



	if (unlikely(IS_PRIVATE(file_inode(file))))

		return 0;



	isp = file_inode(file)->i_security;

	if (isp->smk_mmap == NULL)

		return 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE