Commit 8397927c authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Linus Torvalds
Browse files

lib: bitmap: make nbits parameter of bitmap_full unsigned 



The compiler can generate slightly smaller and simpler code when it
knows that "nbits" is non-negative.  Since no-one passes a negative
bit-count, this shouldn't affect the semantics.

Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0679cc48

include/linux/bitmap.h

+2 −2
Original line number Diff line number Diff line
@@ -89,7 +89,7 @@ 
 */



extern int __bitmap_empty(const unsigned long *bitmap, unsigned int nbits);

extern int __bitmap_full(const unsigned long *bitmap, int bits);

extern int __bitmap_full(const unsigned long *bitmap, unsigned int nbits);

extern int __bitmap_equal(const unsigned long *bitmap1,

                	const unsigned long *bitmap2, int bits);

extern void __bitmap_complement(unsigned long *dst, const unsigned long *src,
@@ -265,7 +265,7 @@ static inline int bitmap_empty(const unsigned long *src, unsigned nbits) 
		return __bitmap_empty(src, nbits);

}



static inline int bitmap_full(const unsigned long *src, int nbits)

static inline int bitmap_full(const unsigned long *src, unsigned int nbits)

{

	if (small_const_nbits(nbits))

		return ! (~(*src) & BITMAP_LAST_WORD_MASK(nbits));

lib/bitmap.c

+2 −2
Original line number Diff line number Diff line
@@ -55,9 +55,9 @@ int __bitmap_empty(const unsigned long *bitmap, unsigned int bits) 
}

EXPORT_SYMBOL(__bitmap_empty);



int __bitmap_full(const unsigned long *bitmap, int bits)

int __bitmap_full(const unsigned long *bitmap, unsigned int bits)

{

	int k, lim = bits/BITS_PER_LONG;

	unsigned int k, lim = bits/BITS_PER_LONG;

	for (k = 0; k < lim; ++k)

		if (~bitmap[k])

			return 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE