Commit 8392853e authored Nov 21, 2019 by Frederic Weisbecker Committed by Ingo Molnar Nov 21, 2019

rackmeter: Use vtime aware kcpustat accessor



Now that we have a vtime safe kcpustat accessor, use it to fetch
CPUTIME_NICE and fix frozen kcpustat values on nohz_full CPUs.

Reported-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wanpeng Li <wanpengli@tencent.com>
Link: https://lkml.kernel.org/r/20191121024430.19938-7-frederic@kernel.org


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 8688f2fb

drivers/macintosh/rack-meter.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -81,13 +81,14 @@ static int rackmeter_ignore_nice;
		*/
		static inline u64 get_cpu_idle_time(unsigned int cpu)
		{
		struct kernel_cpustat *kcpustat = &kcpustat_cpu(cpu);
		u64 retval;

		retval = kcpustat_cpu(cpu).cpustat[CPUTIME_IDLE] +
		kcpustat_cpu(cpu).cpustat[CPUTIME_IOWAIT];
		retval = kcpustat->cpustat[CPUTIME_IDLE] +
		kcpustat->cpustat[CPUTIME_IOWAIT];

		if (rackmeter_ignore_nice)
		retval += kcpustat_cpu(cpu).cpustat[CPUTIME_NICE];
		retval += kcpustat_field(kcpustat, CPUTIME_NICE, cpu);

		return retval;
		}

Admin message