dmaengine: ti: k3-udma: Fix terminated transfer handling (8390318c) · Commits · 戴 / test

When we receive back the descriptor of the terminated transfer the cookie must be marked as completed to make sure that the accounting is correct. In udma_tx_status() the status should be marked as completed if the channel is no longer running (it can only happen if the channel is not yet started for the first time, or after a channel termination). Fixes: ("dmaengine: ti: New driver for K3 UDMA") Signed-off-by:

Peter Ujfalusi <peter.ujfalusi@ti.com> Link: https://lore.kernel.org/r/20200214091441.27535-7-peter.ujfalusi@ti.com Signed-off-by:

Vinod Koul <vkoul@kernel.org>

drivers/dma/ti/k3-udma.c

+15 −14

Original line number	Diff line number	Diff line
		@@ -1097,29 +1097,27 @@ static irqreturn_t udma_ring_irq_handler(int irq, void *data)
		goto out;
		}

		if (uc->cyclic) {
		/* push the descriptor back to the ring */
		if (d == uc->desc) {
		/* active descriptor */
		if (uc->cyclic) {
		udma_cyclic_packet_elapsed(uc);
		vchan_cyclic_callback(&d->vd);
		}
		} else {
		bool desc_done = false;

		if (d == uc->desc) {
		desc_done = udma_is_desc_really_done(uc, d);

		if (desc_done) {
		if (udma_is_desc_really_done(uc, d)) {
		uc->bcnt += d->residue;
		udma_start(uc);
		vchan_cookie_complete(&d->vd);
		} else {
		schedule_delayed_work(&uc->tx_drain.work,
		0);
		}
		}

		if (desc_done)
		vchan_cookie_complete(&d->vd);
		} else {
		/*
		* terminated descriptor, mark the descriptor as
		* completed to update the channel's cookie marker
		*/
		dma_cookie_complete(&d->vd.tx);
		}
		}
		out:
		@@ -2769,6 +2767,9 @@ static enum dma_status udma_tx_status(struct dma_chan *chan,

		ret = dma_cookie_status(chan, cookie, txstate);

		if (!udma_is_chan_running(uc))
		ret = DMA_COMPLETE;

		if (ret == DMA_IN_PROGRESS && udma_is_chan_paused(uc))
		ret = DMA_PAUSED;

Admin message