Commit 838fe188 authored Mar 15, 2016 by Jiri Kosina Committed by David Sterba Mar 22, 2016

btrfs: cleaner_kthread() doesn't need explicit freeze



cleaner_kthread() is not marked freezable, and therefore calling
try_to_freeze() in its context is a pointless no-op.

In addition to that, as has been clearly demonstrated by 80ad623e
("Revert "btrfs: clear PF_NOFREEZE in cleaner_kthread()"), it's perfectly
valid / legal for cleaner_kthread() to stay scheduled out in an arbitrary
place during suspend (in that particular example that was waiting for
reading of extent pages), so there is no need to leave any traces of
freezer in this kthread.

Fixes: 80ad623e ("Revert "btrfs: clear PF_NOFREEZE in cleaner_kthread()")
Fixes: 69624913 ("btrfs: clear PF_NOFREEZE in cleaner_kthread()")
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 0f805531

fs/btrfs/disk-io.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1838,7 +1838,7 @@ static int cleaner_kthread(void *arg)
		*/
		btrfs_delete_unused_bgs(root->fs_info);
		sleep:
		if (!try_to_freeze() && !again) {
		if (!again) {
		set_current_state(TASK_INTERRUPTIBLE);
		if (!kthread_should_stop())
		schedule();

Admin message