Commit 8379cadf authored Jan 19, 2017 by G. Campana Committed by Michael S. Tsirkin Jan 19, 2017

virtio_console: fix a crash in config_work_handler



Using control_work instead of config_work as the 3rd argument to
container_of results in an invalid portdev pointer. Indeed, the work
structure is initialized as below:

    INIT_WORK(&portdev->config_work, &config_work_handler);

It leads to a crash when portdev->vdev is dereferenced later. This
bug
is triggered when the guest uses a virtio-console without multiport
feature and receives a config_changed virtio interrupt.

Signed-off-by: G. Campana <gcampana@quarkslab.com>
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

parent 532e15af

drivers/char/virtio_console.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1862,7 +1862,7 @@ static void config_work_handler(struct work_struct *work)
		{
		struct ports_device *portdev;

		portdev = container_of(work, struct ports_device, control_work);
		portdev = container_of(work, struct ports_device, config_work);
		if (!use_multiport(portdev)) {
		struct virtio_device *vdev;
		struct port *port;

Admin message