Commit 83761f96 authored Jan 29, 2019 by Krzysztof Kozlowski Committed by Lee Jones Feb 07, 2019

mfd: sec-core: Return gracefully instead of BUG() if device cannot match



Replace impossible BUG() in probe with a proper return.  This can be
triggered only in case of a clear bug (e.g. adding broken half-support
for new S2MPSXX flavor) but BUG() is discouraged and the boot process
can actually try to continue.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

parent 9f208eca

drivers/mfd/sec-core.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -471,8 +471,9 @@ static int sec_pmic_probe(struct i2c_client *i2c,
		num_sec_devs = ARRAY_SIZE(s2mpu02_devs);
		break;
		default:
		/* If this happens the probe function is problem */
		BUG();
		dev_err(&i2c->dev, "Unsupported device type (%lu)\n",
		sec_pmic->device_type);
		return -ENODEV;
		}
		ret = devm_mfd_add_devices(sec_pmic->dev, -1, sec_devs, num_sec_devs,
		NULL, 0, NULL);

Admin message