Commit 835d89e9 authored Apr 14, 2017 by Christophe JAILLET Committed by Shaohua Li Apr 14, 2017

md-cluster: Fix a memleak in an error handling path



We know that 'bm_lockres' is NULL here, so 'lockres_free(bm_lockres)' is a
no-op. According to resource handling in case of error a few lines below,
it is likely that 'bitmap_free(bitmap)' was expected instead.

Fixes: b98938d1 ("md-cluster: introduce cluster_check_sync_size")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>

parent 78b6350d

drivers/md/md-cluster.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1127,7 +1127,7 @@ int cluster_check_sync_size(struct mddev *mddev)
		bm_lockres = lockres_init(mddev, str, NULL, 1);
		if (!bm_lockres) {
		pr_err("md-cluster: Cannot initialize %s\n", str);
		lockres_free(bm_lockres);
		bitmap_free(bitmap);
		return -1;
		}
		bm_lockres->flags \|= DLM_LKF_NOQUEUE;

Admin message