Commit 835bcec5 authored Jan 02, 2018 by Dave Young Committed by Ingo Molnar Jan 03, 2018

x86/efi: Fix kernel param add_efi_memmap regression



'add_efi_memmap' is an early param, but do_add_efi_memmap() has no
chance to run because the code path is before parse_early_param().
I believe it worked when the param was introduced but probably later
some other changes caused the wrong order and nobody noticed it.

Move efi_memblock_x86_reserve_range() after parse_early_param()
to fix it.

Signed-off-by: Dave Young <dyoung@redhat.com>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Cc: Ge Song <ge.song@hxt-semitech.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20180102172110.17018-2-ard.biesheuvel@linaro.org


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 30a7acd5

arch/x86/kernel/setup.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -906,9 +906,6 @@ void __init setup_arch(char **cmdline_p)
		set_bit(EFI_BOOT, &efi.flags);
		set_bit(EFI_64BIT, &efi.flags);
		}

		if (efi_enabled(EFI_BOOT))
		efi_memblock_x86_reserve_range();
		#endif

		x86_init.oem.arch_setup();
		@@ -962,6 +959,8 @@ void __init setup_arch(char **cmdline_p)

		parse_early_param();

		if (efi_enabled(EFI_BOOT))
		efi_memblock_x86_reserve_range();
		#ifdef CONFIG_MEMORY_HOTPLUG
		/*
		* Memory used by the kernel cannot be hot-removed because Linux

Admin message