Commit 835112b2 authored Nov 17, 2015 by Eliad Peller Committed by Johannes Berg Dec 02, 2015

mac80211: don't teardown sdata on sdata stop



Interfaces are being initialized (setup) on addition,
and torn down on removal.

However, p2p device is being torn down when stopped,
resulting in the next p2p start operation being done
on uninitialized interface.

Solve it by calling ieee80211_teardown_sdata() only
on interface removal (for the non-netdev case).

Signed-off-by: Eliad Peller <eliadx.peller@intel.com>
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
[squashed in fix to call teardown after unregister]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent ac062197

net/mac80211/iface.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1862,6 +1862,7 @@ void ieee80211_if_remove(struct ieee80211_sub_if_data *sdata)
		unregister_netdevice(sdata->dev);
		} else {
		cfg80211_unregister_wdev(&sdata->wdev);
		ieee80211_teardown_sdata(sdata);
		kfree(sdata);
		}
		}
		@@ -1871,7 +1872,6 @@ void ieee80211_sdata_stop(struct ieee80211_sub_if_data *sdata)
		if (WARN_ON_ONCE(!test_bit(SDATA_STATE_RUNNING, &sdata->state)))
		return;
		ieee80211_do_stop(sdata, true);
		ieee80211_teardown_sdata(sdata);
		}

		void ieee80211_remove_interfaces(struct ieee80211_local *local)

Admin message