sctp: remove useless start_fail from sctp_ht_iter in proc (834539e6) · Commits · 戴 / test

After changing rhashtable_walk_start to return void, start_fail would never be set other value than 0, and the checking for start_fail is pointless, so remove it. Fixes: ("rhashtable: Change rhashtable_walk_start to return void") Signed-off-by:

Xin Long <lucien.xin@gmail.com> Acked-by:

Neil Horman <nhorman@tuxdriver.com> Acked-by:

Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/sctp/proc.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -215,7 +215,6 @@ static const struct seq_operations sctp_eps_ops = {
		struct sctp_ht_iter {
		struct seq_net_private p;
		struct rhashtable_iter hti;
		int start_fail;
		};

		static void sctp_transport_seq_start(struct seq_file seq, loff_t *pos)
		@@ -224,7 +223,6 @@ static void sctp_transport_seq_start(struct seq_file seq, loff_t *pos)

		sctp_transport_walk_start(&iter->hti);

		iter->start_fail = 0;
		return sctp_transport_get_idx(seq_file_net(seq), &iter->hti, *pos);
		}

		@@ -232,8 +230,6 @@ static void sctp_transport_seq_stop(struct seq_file seq, void v)
		{
		struct sctp_ht_iter *iter = seq->private;

		if (iter->start_fail)
		return;
		sctp_transport_walk_stop(&iter->hti);
		}

Admin message