Commit 832e3ca6 authored Dec 12, 2006 by Ian McDonald Committed by David S. Miller Dec 13, 2006

[DCCP] ccid3: return value in ccid3_hc_rx_calc_first_li



In a recent patch we introduced invalid return codes which will result in the
opposite of what is intended (i.e. send more packets in face of peculiar
network conditions).

This fixes it by returning ~0 which means not calculated as per
dccp_li_hist_calc_i_mean.

Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

parent e1b4b9f3

net/dccp/ccids/ccid3.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -845,8 +845,8 @@ found:
		* Find some p such that f(p) = fval; return 1/p [RFC 3448, 6.3.1].
		*/
		if (rtt == 0) { /* would result in divide-by-zero */
		DCCP_WARN("RTT==0, returning 1/p = 1\n");
		return 1000000;
		DCCP_WARN("RTT==0\n");
		return ~0;
		}

		dccp_timestamp(sk, &tstamp);
		@@ -858,7 +858,7 @@ found:
		DCCP_WARN("X_recv==0\n");
		if ((x_recv = hcrx->ccid3hcrx_x_recv) == 0) {
		DCCP_BUG("stored value of X_recv is zero");
		return 1000000;
		return ~0;
		}
		}

Admin message