Commit 830cc351 authored Aug 25, 2017 by Bart Van Assche Committed by Martin K. Petersen Aug 25, 2017

scsi: sd: Remove a useless comparison



This patch avoids that gcc reports the following warning when
building with W=1:

drivers/scsi/sd.c:315:10: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
  if (val >= 0 && val <= T10_PI_TYPE3_PROTECTION)

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent ed91f7ed

drivers/scsi/sd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -312,7 +312,7 @@ protection_type_store(struct device dev, struct device_attribute attr,
		if (err)
		return err;

		if (val >= 0 && val <= T10_PI_TYPE3_PROTECTION)
		if (val <= T10_PI_TYPE3_PROTECTION)
		sdkp->protection_type = val;

		return count;

Admin message