Commit 8302b9bd authored by Quentin Monnet's avatar Quentin Monnet Committed by Daniel Borkmann
Browse files

tools: bpftool: adjust rlimit RLIMIT_MEMLOCK when loading programs, maps 



The limit for memory locked in the kernel by a process is usually set to
64 kbytes by default. This can be an issue when creating large BPF maps
and/or loading many programs. A workaround is to raise this limit for
the current process before trying to create a new BPF map. Changing the
hard limit requires the CAP_SYS_RESOURCE and can usually only be done by
root user (for non-root users, a call to setrlimit fails (and sets
errno) and the program simply goes on with its rlimit unchanged).

There is no API to get the current amount of memory locked for a user,
therefore we cannot raise the limit only when required. One solution,
used by bcc, is to try to create the map, and on getting a EPERM error,
raising the limit to infinity before giving another try. Another
approach, used in iproute2, is to raise the limit in all cases, before
trying to create the map.

Here we do the same as in iproute2: the rlimit is raised to infinity
before trying to load programs or to create maps with bpftool.

Signed-off-by: default avatarQuentin Monnet <quentin.monnet@netronome.com>
Reviewed-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: default avatarMartin KaFai Lau <kafai@fb.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
parent f96afa76

tools/bpf/bpftool/common.c

+8 −0
Original line number Original line Diff line number Diff line
@@ -46,6 +46,7 @@ 
#include <linux/magic.h>

#include <linux/magic.h>

#include <net/if.h>

#include <net/if.h>

#include <sys/mount.h>

#include <sys/mount.h>

#include <sys/resource.h>

#include <sys/stat.h>

#include <sys/stat.h>

#include <sys/types.h>

#include <sys/types.h>

#include <sys/vfs.h>

#include <sys/vfs.h>
@@ -99,6 +100,13 @@ static bool is_bpffs(char *path) 
	return (unsigned long)st_fs.f_type == BPF_FS_MAGIC;

	return (unsigned long)st_fs.f_type == BPF_FS_MAGIC;

}

}





void set_max_rlimit(void)

{

	struct rlimit rinf = { RLIM_INFINITY, RLIM_INFINITY };



	setrlimit(RLIMIT_MEMLOCK, &rinf);

}



static int mnt_bpffs(const char *target, char *buff, size_t bufflen)

static int mnt_bpffs(const char *target, char *buff, size_t bufflen)

{

{

	bool bind_done = false;

	bool bind_done = false;

tools/bpf/bpftool/main.h

+2 −0
Original line number Original line Diff line number Diff line
@@ -100,6 +100,8 @@ bool is_prefix(const char *pfx, const char *str); 
void fprint_hex(FILE *f, void *arg, unsigned int n, const char *sep);

void fprint_hex(FILE *f, void *arg, unsigned int n, const char *sep);

void usage(void) __noreturn;

void usage(void) __noreturn;





void set_max_rlimit(void);



struct pinned_obj_table {

struct pinned_obj_table {

	DECLARE_HASHTABLE(table, 16);

	DECLARE_HASHTABLE(table, 16);

};

};

tools/bpf/bpftool/map.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -1140,6 +1140,8 @@ static int do_create(int argc, char **argv) 
		return -1;

		return -1;

	}

	}





	set_max_rlimit();



	fd = bpf_create_map_xattr(&attr);

	fd = bpf_create_map_xattr(&attr);

	if (fd < 0) {

	if (fd < 0) {

		p_err("map create failed: %s", strerror(errno));

		p_err("map create failed: %s", strerror(errno));

tools/bpf/bpftool/prog.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -995,6 +995,8 @@ static int do_load(int argc, char **argv) 
		goto err_close_obj;

		goto err_close_obj;

	}

	}





	set_max_rlimit();



	err = bpf_object__load(obj);

	err = bpf_object__load(obj);

	if (err) {

	if (err) {

		p_err("failed to load object file");

		p_err("failed to load object file");

CRA Git | Maintained and supported by SUSTech CRA and CCSE