Commit 8301b91b authored by Clemens Ladisch's avatar Clemens Ladisch Committed by Stefan Richter
Browse files

firewire: ohci: add cycle timer quirk for the TI TSB12LV22 

Among the many entries in the TSB12LV22 errata list (TI literature
number SLLS312) is the following:

  PCI Slave reads of the Cycle Timer register may occasionally get an
  incorrect value.
  Software may be able to validate value by reading the register
  multiple times rapidly and evaluating for a reasonable difference.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de> (untested)
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (added #define)
parent cf36df6b

drivers/firewire/ohci.c

+4 −0
Original line number Original line Diff line number Diff line
@@ -231,6 +231,8 @@ static inline struct fw_ohci *fw_ohci(struct fw_card *card) 




static char ohci_driver_name[] = KBUILD_MODNAME;

static char ohci_driver_name[] = KBUILD_MODNAME;





#define PCI_DEVICE_ID_TI_TSB12LV22	0x8009



#define QUIRK_CYCLE_TIMER		1

#define QUIRK_CYCLE_TIMER		1

#define QUIRK_RESET_PACKET		2

#define QUIRK_RESET_PACKET		2

#define QUIRK_BE_HEADERS		4

#define QUIRK_BE_HEADERS		4
@@ -239,6 +241,8 @@ static char ohci_driver_name[] = KBUILD_MODNAME; 
static const struct {

static const struct {

	unsigned short vendor, device, flags;

	unsigned short vendor, device, flags;

} ohci_quirks[] = {

} ohci_quirks[] = {

	{PCI_VENDOR_ID_TI,	PCI_DEVICE_ID_TI_TSB12LV22, QUIRK_CYCLE_TIMER |

							    QUIRK_RESET_PACKET},

	{PCI_VENDOR_ID_TI,	PCI_ANY_ID,	QUIRK_RESET_PACKET},

	{PCI_VENDOR_ID_TI,	PCI_ANY_ID,	QUIRK_RESET_PACKET},

	{PCI_VENDOR_ID_AL,	PCI_ANY_ID,	QUIRK_CYCLE_TIMER},

	{PCI_VENDOR_ID_AL,	PCI_ANY_ID,	QUIRK_CYCLE_TIMER},

	{PCI_VENDOR_ID_NEC,	PCI_ANY_ID,	QUIRK_CYCLE_TIMER},

	{PCI_VENDOR_ID_NEC,	PCI_ANY_ID,	QUIRK_CYCLE_TIMER},

CRA Git | Maintained and supported by SUSTech CRA and CCSE