Commit 82d1ce50 authored by Mariusz Kozlowski's avatar Mariusz Kozlowski Committed by James Bottomley
Browse files

[SCSI] mpt fusion: remove redundant memset 



alloc_fcdev() calls alloc_netdev() which uses kzalloc to alloc all the
memory together with dev->priv region hence no zeroing of structs inside
struct mpt_lan_priv needed.

Signed-off-by: default avatarMariusz Kozlowski <m.kozlowski@tuxland.pl>
Acked-by: default avatar"Moore, Eric Dean" <Eric.Moore@lsil.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent 56876195

drivers/message/fusion/mptlan.c

+3 −5
Original line number Diff line number Diff line
@@ -1345,10 +1345,11 @@ mpt_lan_post_receive_buckets_work(struct work_struct *work) 
static struct net_device *

mpt_register_lan_device (MPT_ADAPTER *mpt_dev, int pnum)

{

	struct net_device *dev = alloc_fcdev(sizeof(struct mpt_lan_priv));

	struct mpt_lan_priv *priv = NULL;

	struct net_device *dev;

	struct mpt_lan_priv *priv;

	u8 HWaddr[FC_ALEN], *a;



	dev = alloc_fcdev(sizeof(struct mpt_lan_priv));

	if (!dev)

		return NULL;
@@ -1360,7 +1361,6 @@ mpt_register_lan_device (MPT_ADAPTER *mpt_dev, int pnum) 
	priv->mpt_dev = mpt_dev;

	priv->pnum = pnum;



	memset(&priv->post_buckets_task, 0, sizeof(priv->post_buckets_task));

	INIT_DELAYED_WORK(&priv->post_buckets_task,

			  mpt_lan_post_receive_buckets_work);

	priv->post_buckets_active = 0;
@@ -1385,8 +1385,6 @@ mpt_register_lan_device (MPT_ADAPTER *mpt_dev, int pnum) 
	spin_lock_init(&priv->txfidx_lock);

	spin_lock_init(&priv->rxfidx_lock);



	memset(&priv->stats, 0, sizeof(priv->stats));



	/*  Grab pre-fetched LANPage1 stuff. :-) */

	a = (u8 *) &mpt_dev->lan_cnfg_page1.HardwareAddressLow;

CRA Git | Maintained and supported by SUSTech CRA and CCSE