Commit 82d130ff authored Mar 28, 2013 by Miao Xie Committed by Josef Bacik Mar 28, 2013

Btrfs: fix wrong return value of btrfs_lookup_csum()



If we don't find the expected csum item, but find a csum item which is
adjacent to the specified extent, we should return -EFBIG, or we should
return -ENOENT. But btrfs_lookup_csum() return -EFBIG even the csum item
is not adjacent to the specified extent. Fix it.

Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>

parent 39847c4d

fs/btrfs/file-item.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -118,9 +118,11 @@ struct btrfs_csum_item btrfs_lookup_csum(struct btrfs_trans_handle trans,
		csums_in_item = btrfs_item_size_nr(leaf, path->slots[0]);
		csums_in_item /= csum_size;

		if (csum_offset >= csums_in_item) {
		if (csum_offset == csums_in_item) {
		ret = -EFBIG;
		goto fail;
		} else if (csum_offset > csums_in_item) {
		goto fail;
		}
		}
		item = btrfs_item_ptr(leaf, path->slots[0], struct btrfs_csum_item);

Admin message