Commit 82ce6eb1 authored May 15, 2019 by Jeffrin Jose T Committed by Pablo Neira Ayuso May 21, 2019

selftests: netfilter: missing error check when setting up veth interface



A test for the basic NAT functionality uses ip command which needs veth
device. There is a condition where the kernel support for veth is not
compiled into the kernel and the test script breaks. This patch contains
code for reasonable error display and correct code exit.

Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent 719c7d56

tools/testing/selftests/netfilter/nft_nat.sh

+5 −1

Original line number	Diff line number	Diff line
		@@ -24,7 +24,11 @@ ip netns add ns0
		ip netns add ns1
		ip netns add ns2

		ip link add veth0 netns ns0 type veth peer name eth0 netns ns1
		ip link add veth0 netns ns0 type veth peer name eth0 netns ns1 > /dev/null 2>&1
		if [ $? -ne 0 ];then
		echo "SKIP: No virtual ethernet pair device support in kernel"
		exit $ksft_skip
		fi
		ip link add veth1 netns ns0 type veth peer name eth0 netns ns2

		ip -net ns0 link set lo up

Admin message