Commit 82a3242e authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

sysfs: remove "last sysfs file:" line from the oops messages 



On some arches (x86, sh, arm, unicore, powerpc) the oops message would
print out the last sysfs file accessed.

This was very useful in finding a number of sysfs and driver core bugs
in the 2.5 and early 2.6 development days, but it has been a number of
years since this file has actually helped in debugging anything that
couldn't also be trivially determined from the stack traceback.

So it's time to delete the line.  This is good as we need all the space
we can get for oops messages at times on consoles.

Acked-by: default avatarPhil Carmody <ext-phil.2.carmody@nokia.com>
Acked-by: default avatarIngo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent a236c717

arch/arm/kernel/traps.c

+0 −1
Original line number Diff line number Diff line
@@ -234,7 +234,6 @@ static int __die(const char *str, int err, struct thread_info *thread, struct pt 


	printk(KERN_EMERG "Internal error: %s: %x [#%d]" S_PREEMPT S_SMP "\n",

	       str, err, ++die_counter);

	sysfs_printk_last_file();



	/* trap and error numbers are mostly meaningless on ARM */

	ret = notify_die(DIE_OOPS, str, regs, err, tsk->thread.trap_no, SIGSEGV);

arch/powerpc/kernel/traps.c

+0 −1
Original line number Diff line number Diff line
@@ -143,7 +143,6 @@ int die(const char *str, struct pt_regs *regs, long err) 
#endif

		printk("%s\n", ppc_md.name ? ppc_md.name : "");



		sysfs_printk_last_file();

		if (notify_die(DIE_OOPS, str, regs, err, 255,

			       SIGSEGV) == NOTIFY_STOP)

			return 1;

arch/sh/kernel/traps_32.c

+0 −1
Original line number Diff line number Diff line
@@ -87,7 +87,6 @@ void die(const char * str, struct pt_regs * regs, long err) 
	bust_spinlocks(1);



	printk("%s: %04lx [#%d]\n", str, err & 0xffff, ++die_counter);

	sysfs_printk_last_file();

	print_modules();

	show_regs(regs);

arch/unicore32/kernel/traps.c

+0 −1
Original line number Diff line number Diff line
@@ -192,7 +192,6 @@ static int __die(const char *str, int err, struct thread_info *thread, 


	printk(KERN_EMERG "Internal error: %s: %x [#%d]\n",

	       str, err, ++die_counter);

	sysfs_printk_last_file();



	/* trap and error numbers are mostly meaningless on UniCore */

	ret = notify_die(DIE_OOPS, str, regs, err, tsk->thread.trap_no, \

arch/x86/kernel/dumpstack.c

+0 −1
Original line number Diff line number Diff line
@@ -279,7 +279,6 @@ int __kprobes __die(const char *str, struct pt_regs *regs, long err) 
	printk("DEBUG_PAGEALLOC");

#endif

	printk("\n");

	sysfs_printk_last_file();

	if (notify_die(DIE_OOPS, str, regs, err,

			current->thread.trap_no, SIGSEGV) == NOTIFY_STOP)

		return 1;

CRA Git | Maintained and supported by SUSTech CRA and CCSE