Commit 82984114 authored Oct 06, 2005 by Linus Torvalds

Avoid 'names_cache' memory leak with CONFIG_AUDITSYSCALL



The nameidata "last.name" is always allocated with "__getname()", and
should always be free'd with "__putname()".

Using "putname()" without the underscores will leak memory, because the
allocation will have been hidden from the AUDITSYSCALL code.

Arguably the real bug is that the AUDITSYSCALL code is really broken,
but in the meantime this fixes the problem people see.

Reported by Robert Derr, patch by Rick Lindsley.

Acked-by: Al Viro <viro@ftp.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent edb4a353

fs/namei.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1551,19 +1551,19 @@ do_link:
		if (nd->last_type != LAST_NORM)
		goto exit;
		if (nd->last.name[nd->last.len]) {
		putname(nd->last.name);
		__putname(nd->last.name);
		goto exit;
		}
		error = -ELOOP;
		if (count++==32) {
		putname(nd->last.name);
		__putname(nd->last.name);
		goto exit;
		}
		dir = nd->dentry;
		down(&dir->d_inode->i_sem);
		path.dentry = __lookup_hash(&nd->last, nd->dentry, nd);
		path.mnt = nd->mnt;
		putname(nd->last.name);
		__putname(nd->last.name);
		goto do_last;
		}

Admin message