driver core: dev_set_drvdata can no longer fail (8283b491) · Commits · 戴 / test

drivers/iommu/exynos-iommu.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -542,12 +542,7 @@ static int exynos_sysmmu_probe(struct platform_device *pdev)
		goto err_alloc;
		}

		ret = dev_set_drvdata(dev, data);
		if (ret) {
		dev_dbg(dev, "Unabled to initialize driver data\n");
		goto err_init;
		}

		dev_set_drvdata(dev, data);
		data->nsfrs = pdev->num_resources / 2;
		data->sfrbases = kmalloc(sizeof(data->sfrbases) data->nsfrs,
		GFP_KERNEL);

+1 −7

Original line number	Diff line number	Diff line
		@@ -349,7 +349,6 @@ struct vfio_device vfio_group_create_device(struct vfio_group group,
		void *device_data)
		{
		struct vfio_device *device;
		int ret;

		device = kzalloc(sizeof(*device), GFP_KERNEL);
		if (!device)
		@@ -360,12 +359,7 @@ struct vfio_device vfio_group_create_device(struct vfio_group group,
		device->group = group;
		device->ops = ops;
		device->device_data = device_data;

		ret = dev_set_drvdata(dev, device);
		if (ret) {
		kfree(device);
		return ERR_PTR(ret);
		}
		dev_set_drvdata(dev, device);

		/* No need to get group_lock, caller has group reference */
		vfio_group_get(group);