IB/core: Allow vlan link local address based RoCE GIDs (823b23da) · Commits · 戴 / test

IPv6 link local address for a VLAN netdevice has nothing to do with its resemblance with the default GID, because VLAN link local GID is in different layer 2 domain. Now that RoCE MAD packet processing and route resolution consider the right GID index, there is no need for an unnecessary check which prevents the addition of vlan based IPv6 link local GIDs. Signed-off-by:

Parav Pandit <parav@mellanox.com> Reviewed-by:

Daniel Jurgens <danielj@mellanox.com> Signed-off-by:

Leon Romanovsky <leonro@mellanox.com> Signed-off-by:

Jason Gunthorpe <jgg@mellanox.com>

drivers/infiniband/core/cache.c

+4 −23

Original line number	Diff line number	Diff line
		@@ -543,30 +543,11 @@ out_unlock:
		int ib_cache_gid_add(struct ib_device *ib_dev, u8 port,
		union ib_gid gid, struct ib_gid_attr attr)
		{
		struct net_device *idev;
		unsigned long mask;
		int ret;

		idev = ib_device_get_netdev(ib_dev, port);
		if (idev && attr->ndev != idev) {
		union ib_gid default_gid;

		/* Adding default GIDs is not permitted */
		make_default_gid(idev, &default_gid);
		if (!memcmp(gid, &default_gid, sizeof(*gid))) {
		dev_put(idev);
		return -EPERM;
		}
		}
		if (idev)
		dev_put(idev);

		mask = GID_ATTR_FIND_MASK_GID \|
		unsigned long mask = GID_ATTR_FIND_MASK_GID \|
		GID_ATTR_FIND_MASK_GID_TYPE \|
		GID_ATTR_FIND_MASK_NETDEV;

		ret = __ib_cache_gid_add(ib_dev, port, gid, attr, mask, false);
		return ret;
		return __ib_cache_gid_add(ib_dev, port, gid, attr, mask, false);
		}

		static int

Admin message