Commit 82324809 authored Sep 25, 2011 by Jonthan Brassow Committed by Alasdair G Kergon Sep 25, 2011

dm: raid fix write_mostly arg validation



Fix off-by-one error in validation of write_mostly.

The user-supplied value given for the 'write_mostly' argument must be an
index starting at 0.  The validation of the supplied argument failed to
check for 'N' ('>' vs '>='), which would have caused an access beyond the
end of the array.

Reported-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>

parent 876fbba1

drivers/md/dm-raid.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -449,7 +449,7 @@ static int parse_raid_params(struct raid_set rs, char *argv,
		rs->ti->error = "write_mostly option is only valid for RAID1";
		return -EINVAL;
		}
		if (value > rs->md.raid_disks) {
		if (value >= rs->md.raid_disks) {
		rs->ti->error = "Invalid write_mostly drive index given";
		return -EINVAL;
		}

Admin message