Commit 82303457 authored Aug 21, 2019 by Sylwester Nawrocki Committed by Krzysztof Kozlowski Aug 22, 2019

soc: samsung: chipid: Remove the regmap lookup error log



In commit 40d8aff6 ("soc: samsung: chipid: Convert exynos-chipid
driver to use the regmap API") of_find_compatible_node() call was
substituted with syscon_regmap_lookup_by_compatible() but also an error
log was added for case where lookup fails. On multiplatform the lookup
will always fail on any non-samsung device so the log is incorrect.
Remove the error log and just return an error code from
syscon_regmap_lookup_by_compatible() which internally calls
of_find_compatible_node().

Reported-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

parent 3636e821

drivers/soc/samsung/exynos-chipid.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -56,10 +56,8 @@ int __init exynos_chipid_early_init(void)
		int ret;

		regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid");
		if (IS_ERR(regmap)) {
		pr_err("Failed to get CHIPID regmap\n");
		if (IS_ERR(regmap))
		return PTR_ERR(regmap);
		}

		ret = regmap_read(regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id);
		if (ret < 0)

Admin message