Commit 822e1a90 authored Oct 16, 2020 by Diana Craciun Committed by Alex Williamson Oct 19, 2020

vfio/fsl-mc: fix the return of the uninitialized variable ret



The vfio_fsl_mc_reflck_attach function may return, on success path,
an uninitialized variable. Fix the problem by initializing the return
variable to 0.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: f2ba7e8c ("vfio/fsl-mc: Added lock support in preparation for interrupt handling")
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Diana Craciun <diana.craciun@oss.nxp.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

parent 15924637

drivers/vfio/fsl-mc/vfio_fsl_mc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -58,7 +58,7 @@ static struct vfio_fsl_mc_reflck *vfio_fsl_mc_reflck_alloc(void)

		static int vfio_fsl_mc_reflck_attach(struct vfio_fsl_mc_device *vdev)
		{
		int ret;
		int ret = 0;

		mutex_lock(&reflck_lock);
		if (is_fsl_mc_bus_dprc(vdev->mc_dev)) {

Admin message