Commit 8221324b authored by Ray Jui's avatar Ray Jui Committed by Wolfram Sang
Browse files

i2c: iproc: Change driver to use 'BIT' macro 



Change the iProc I2C driver to use the 'BIT' macro from all '1 << XXX'
bit operations to get rid of compiler warning and improve readability of
the code

Signed-off-by: default avatarRay Jui <ray.jui@broadcom.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent d303ce59

drivers/i2c/busses/i2c-bcm-iproc.c

+3 −3
Original line number Diff line number Diff line
@@ -717,7 +717,7 @@ static int bcm_iproc_i2c_xfer_single_msg(struct bcm_iproc_i2c_dev *iproc_i2c, 


			/* mark the last byte */

			if (i == msg->len - 1)

				val |= 1 << M_TX_WR_STATUS_SHIFT;

				val |= BIT(M_TX_WR_STATUS_SHIFT);



			iproc_i2c_wr_reg(iproc_i2c, M_TX_OFFSET, val);

		}
@@ -844,7 +844,7 @@ static int bcm_iproc_i2c_cfg_speed(struct bcm_iproc_i2c_dev *iproc_i2c) 


	iproc_i2c->bus_speed = bus_speed;

	val = iproc_i2c_rd_reg(iproc_i2c, TIM_CFG_OFFSET);

	val &= ~(1 << TIM_CFG_MODE_400_SHIFT);

	val &= ~BIT(TIM_CFG_MODE_400_SHIFT);

	val |= (bus_speed == 400000) << TIM_CFG_MODE_400_SHIFT;

	iproc_i2c_wr_reg(iproc_i2c, TIM_CFG_OFFSET, val);
@@ -995,7 +995,7 @@ static int bcm_iproc_i2c_resume(struct device *dev) 


	/* configure to the desired bus speed */

	val = iproc_i2c_rd_reg(iproc_i2c, TIM_CFG_OFFSET);

	val &= ~(1 << TIM_CFG_MODE_400_SHIFT);

	val &= ~BIT(TIM_CFG_MODE_400_SHIFT);

	val |= (iproc_i2c->bus_speed == 400000) << TIM_CFG_MODE_400_SHIFT;

	iproc_i2c_wr_reg(iproc_i2c, TIM_CFG_OFFSET, val);

CRA Git | Maintained and supported by SUSTech CRA and CCSE